Add macro to simplify into_full_block implementations#9294
Merged
Conversation
macladson
added
code-quality
ready-for-review
chong-he
approved these changes
May 19, 2026
chong-he
left a comment
chong-he
left a comment
Member
There was a problem hiding this comment.
I understand what this PR is doing but I can't say I understand everything in the macro itself.
This is to use macro to replace the repeated into_full_block function for each fork, with a flexibility of having some extra fields in the body for some forks.
Nice simplification, looks good to me overall.
Comment on lines
-436
to
-437
| // NOTE: It might be nice to come up with a `superstruct` pattern to abstract over this before | ||
| // the first fork after Bellatrix. |
michaelsproul
added
ready-for-merge
Merge Queue Status
This pull request spent 29 minutes 37 seconds in the queue, including 27 minutes 42 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Use a macro to remove the repetitive fork variant boilerplate in
signed_beacon_block.rswhen implementinginto_full_blockfor the variousSignedBeaconBlockvariants